fix: warn and exit early when deploy has no resources - #377
Open
Swigler wants to merge 1 commit into
Open
Conversation
Client-mode endpoints (image=...) produce an empty resources dict in the manifest because they have no handler code to deploy. Previously, flash deploy would upload the archive, create the environment, and print "✓ deployed to production" even though no serverless endpoint was provisioned — a misleading success for a no-op. Now detect the empty resources before uploading and print a clear warning explaining that client-mode endpoints provision on first call. Closes runpod#365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect empty
resourcesin the manifest before uploading and print a clear warning instead of a misleading "✓ deployed to production".Fixes #365
What was wrong
Client-mode endpoints (
image=...) are excluded from the manifest'sresourcesdict because they don't define serverless handlers.flash deploywould:No serverless endpoint was actually provisioned. The user sees success but has nothing deployed. The endpoint only gets created lazily on first
endpoint()call.What changed
Added an early check in
_resolve_and_deploy()aftervalidate_local_manifest():resourcesis empty, print a warning explaining that client-mode endpoints provision on first callThis is the minimal fix. A more comprehensive approach (eagerly provisioning client-mode endpoints at deploy time) would require design discussion around the lazy-loading architecture.
Test plan