Repository navigation
Fix: stream docker logs - #657
Merged
Merged
Conversation
runabol
force-pushed
the
stream-docker-logs-fix
branch
2 times, most recently
from
November 11, 2026 16:18
d419988 to
48eaf5e
Compare
runabol
force-pushed
the
stream-docker-logs-fix
branch
from
November 11, 2026 16:34
48eaf5e to
e84075b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait()andprobeContainer(): a backgroundio.Copycould still be reading while the log reader (and underlying connection) was closed, which spammederror reading the std outin prod even when tasks succeeded.defer ClosewithstreamLogs(), which closes the reader, waits for the copy goroutine, and only logs unexpected read errors.net.ErrClosed,http.ErrBodyReadAfterClose,http: read on closed response body, etc.). Prod logs showed e.g.read unix @->/run/docker.sock: use of closed network connection— normal teardown of the Moby client socket during log-follow shutdown, not task failure.