Repository navigation
docker: let log copy drain before closing stdout on container exit - #651
Draft
raymondfeliz wants to merge 2 commits into
Draft
raymondfeliz wants to merge 2 commits into
raymondfeliz wants to merge 2 commits into
Conversation
raymondfeliz
force-pushed
the
fix/docker-wait-drain-logs
branch
2 times, most recently
from
November 4, 2026 23:28
bf05096 to
54c0723
Compare
raymondfeliz
force-pushed
the
fix/docker-wait-drain-logs
branch
from
November 4, 2026 23:42
54c0723 to
f1547b0
Compare
The hand-rolled reader assumed each Read filled a whole frame, so frames split across reads dropped bytes and padded the log with NULs, which Postgres rejects on insert.
raymondfeliz
force-pushed
the
fix/docker-wait-drain-logs
branch
from
November 5, 2026 00:10
f1547b0 to
9fca543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let log copy drain before closing stdout on container exit and a test