Skip to content

chore: fix StandardRB offense in email templates spec - #7446

Open
KoushikSagarr wants to merge 1 commit into
rubyforgood:mainfrom
KoushikSagarr:standard-compliance-email-templates-spec
Open

KoushikSagarr wants to merge 1 commit into
rubyforgood:mainfrom
KoushikSagarr:standard-compliance-email-templates-spec

Conversation

@KoushikSagarr

@KoushikSagarr KoushikSagarr commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

What github issue is this PR for, if any?

Not associated with a specific issue.

What changed, and why?

  • Replaced File.read(Rails.root.join(file_path)) with Rails.root.join(file_path).read in spec/views/templates/email_templates_spec.rb.
  • Removed the corresponding Rails/RootPathnameMethods entry from .standard_todo.yml.
  • Kept the changes strictly limited to resolving the existing StandardRB offense in the email templates spec.

This is another small, independently reviewable contribution toward improving StandardRB compliance across the CASA codebase.

How is this tested? (please write rspec and jest tests!) 💖💪

  • StandardRB: 0 offenses in spec/views/templates/email_templates_spec.rb.
  • RSpec: 14 examples, 0 failures.
  • Git diff: git diff --check passed with no whitespace errors.

Focused validation was run successfully using the established Docker environment.

Screenshots please :)

Not applicable — this PR only changes a Ruby spec and its StandardRB TODO entry. No UI changes.

Feelings gif (optional)

One less StandardRB offense, one step closer to a cleaner CASA codebase! 💪

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant