Skip to content

Follow-up to #7412: tighten remember_me sign-in specs - #7436

Merged
compwron merged 1 commit into
mainfrom
tighten-sign-in-remember-me-specs
Nov 20, 2026
Merged

compwron merged 1 commit into
mainfrom
tighten-sign-in-remember-me-specs

Conversation

@compwron

Copy link
Copy Markdown
Collaborator

Follow-up to #7402 / #7412.

  • Failed sign-in with remember_me now asserts 200 OK instead of not redirect (which would also pass on a 500). Verified both specs fail with ActiveModel::UnknownAttributeError when the sign_in_params override is reverted.
  • Comment on the override explaining why it exists and that it bypasses devise_parameter_sanitizer.
  • Dropped an unrelated blank-line change in Users::SessionsController.

🤖 Generated with Claude Code

Assert a concrete 200 for failed sign-in with remember_me (verified the
specs fail with UnknownAttributeError when the override is removed).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added 🧪 Tests Tests ruby Touches Ruby code labels Nov 20, 2026
@compwron
compwron merged commit 4af3259 into main Nov 20, 2026
6 of 12 checks passed
@compwron
compwron deleted the tighten-sign-in-remember-me-specs branch November 20, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant