Repository navigation
Follow-up to #7412: tighten remember_me sign-in specs - #7436
Merged
Merged
Conversation
Assert a concrete 200 for failed sign-in with remember_me (verified the specs fail with UnknownAttributeError when the override is removed). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7402 / #7412.
remember_menow asserts200 OKinstead ofnot redirect(which would also pass on a 500). Verified both specs fail withActiveModel::UnknownAttributeErrorwhen thesign_in_paramsoverride is reverted.devise_parameter_sanitizer.Users::SessionsController.🤖 Generated with Claude Code