Skip to content

Upgrade node to v24 - #6708

Merged
FireLemons merged 4 commits into
rubyforgood:mainfrom
hexdevs:sb-upgrade-node-to-v24
Feb 11, 2026
Merged

FireLemons merged 4 commits into
rubyforgood:mainfrom
hexdevs:sb-upgrade-node-to-v24

Conversation

@stefannibrasil

@stefannibrasil stefannibrasil commented Feb 10, 2026 •

Copy link
Copy Markdown
Contributor

What github issue is this PR for, if any?

Closes #6688

What changed, and why?

  • upgrade node to 24.x since 22.x is not being supported anymore (only security patches), and heroku will require newer versions soon
  • Dockerfile: the image couldn't be built without explicitly downloading this node's version. Maybe on Ruby's 3.3.10 alpine, it will be available and we don't need these lines.

My local env generated some peer: true changes in the package.json file. However, this seems to be a bug related to npm. I removed them from this PR to isolate the node changes.

How is this tested?

Tests are passing! I also built js and css, and checked the app locally and didn't find any errors, and no console's errors either:

casa.node.24.mov

I am also happy to QA this branch in the QA env, if needed.

@github-actions github-actions Bot added dependencies Touches dependency files javascript Touches JavaScript code labels Feb 10, 2026
@stefannibrasil stefannibrasil changed the title Sb upgrade node to v24 Upgrade node to v24 Feb 11, 2026
The image couldn't be built without explicitely
downloading this node's version. Maybe on Ruby's 3.3.10
alpine, it will be available and we don't need these lines.
Comment thread doc/LINUX_SETUP.md
# Install NVM and Node JS
# you can use curl
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.4/install.sh | bash

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted from https://github.com/nvm-sh/nvm?tab=readme-ov-file#install--update-script

I do not use Linux, so I couldn't verify this works, though.

This seems to be a bug from npm. Removing them from
this PR to isolate the node upgrade changes only.
@stefannibrasil
stefannibrasil marked this pull request as ready for review February 11, 2026 00:28
@FireLemons

Copy link
Copy Markdown
Collaborator

🏅

@FireLemons
FireLemons merged commit 1916263 into rubyforgood:main Feb 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Touches dependency files javascript Touches JavaScript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update node to v24

2 participants