Repository navigation
Remove dead latest_news view and sortable_fields partials - #3039
Merged
Merged
Conversation
The latest_news view has no route or action, so its "Show all"/type filter partial (old jQuery) and the unrendered _sortable_fields partial never run. Their helpers and the bookmarks @sortable_fields ivar had no other readers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 1 Skim 👀 deletes unreachable views and their only helpers
Removes old jQuery filter code that no page can reach.
What is the goal of this PR and why is this important?
resources/latest_newshas no route or controller action.shared/_sortable_fields_btn, is a "Show all"/type filter, not a sort.shared/_sortable_fields(never rendered)sortable_field_display_nameandchecked?helpers@sortable_fieldsinBookmarksController(no view reads it)How did you approach the change?
checked?define their own local method.Features seed (optional)
🤖 Generated with Claude Code