Skip to content

Remove dead latest_news view and sortable_fields partials - #3039

Merged
maebeale merged 1 commit into
mainfrom
maebeale/_sortable_fields_btn-dead-remove
Nov 20, 2026
Merged

maebeale merged 1 commit into
mainfrom
maebeale/_sortable_fields_btn-dead-remove

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 1 Skim 👀 deletes unreachable views and their only helpers

Removes old jQuery filter code that no page can reach.

What is the goal of this PR and why is this important?

  • resources/latest_news has no route or controller action.
  • Its only partial, shared/_sortable_fields_btn, is a "Show all"/type filter, not a sort.
  • Deleting it also orphans:
    • shared/_sortable_fields (never rendered)
    • sortable_field_display_name and checked? helpers
    • @sortable_fields in BookmarksController (no view reads it)

How did you approach the change?

  • Grepped app, lib, config, and spec for each name before deleting.
  • Specs that call checked? define their own local method.
  • Bookmarks, helper, and resources request specs pass.

Features seed (optional)

  • Added a features seed (optional) — n/a, no user-facing change

🤖 Generated with Claude Code

The latest_news view has no route or action, so its "Show all"/type
filter partial (old jQuery) and the unrendered _sortable_fields partial
never run. Their helpers and the bookmarks @sortable_fields ivar had no
other readers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maebeale
maebeale marked this pull request as ready for review November 20, 2026 13:18
@maebeale
maebeale merged commit 1600ce6 into main Nov 20, 2026
4 checks passed
@maebeale
maebeale deleted the maebeale/_sortable_fields_btn-dead-remove branch November 20, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant