Skip to content

Story ideas: funder-only option is admin-only - #3031

Open
maebeale wants to merge 3 commits into
mainfrom
maebeale/screenshot-multiple-clicks
Open

maebeale wants to merge 3 commits into
mainfrom
maebeale/screenshot-multiple-clicks

Conversation

@maebeale

@maebeale maebeale commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 1 Skim 👀 view-only: funder-only checkbox gated to admins on the story idea form

Submitters no longer see the funder-only box — they could tick it alongside public-sharing permission, which contradict each other.

What is the goal of this PR and why is this important?

  • Permission is the submitter's consent; funder-only is a staff visibility call.
  • Splitting who sets each removes the "both checked" contradiction.

How did you approach the change?

  • Funder-only box renders only for allowed_to?(:manage?, StoryIdea), in an admin-only panel.
    • Admins set it on new/edit; it carries to the story on promotion (unchanged).
    • Story form keeps its own funder-only flag (unchanged).
  • Dropped the "training-scholarship deliverable" hint.
  • No param stripping — UI gating only, per house convention.

Features seed (optional)

  • Added a features seed

UI Testing Checklist

  • Submitter on new story idea / Story Share submit: only the permission checkbox
  • Admin on new/edit story idea: funder-only box in blue admin panel

Anything else to add?

  • Submitters can't self-flag deliverables now; staff flag them at triage.

🤖 Generated with Claude Code

maebeale and others added 2 commits November 19, 2026 21:19
Submitters could check both the public-sharing permission and funder-only,
which contradict each other. One radio choice keeps them exclusive without
new JavaScript, and a funder-only story no longer records public permission.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maebeale maebeale changed the title Story ideas: pick public sharing or funder-only, not both HOLD: Story ideas: pick public sharing or funder-only, not both Nov 20, 2026
Submitters were offered both public-sharing permission and funder-only,
which contradict each other. Permission is the submitter's consent;
funder-only is a staff visibility call, so admins set it during triage and
it carries over on promotion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maebeale maebeale changed the title HOLD: Story ideas: pick public sharing or funder-only, not both Story ideas: funder-only option is admin-only Nov 20, 2026
@maebeale
maebeale marked this pull request as ready for review November 20, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant