Repository navigation
Conversation
Submitters could check both the public-sharing permission and funder-only, which contradict each other. One radio choice keeps them exclusive without new JavaScript, and a funder-only story no longer records public permission. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Submitters were offered both public-sharing permission and funder-only, which contradict each other. Permission is the submitter's consent; funder-only is a staff visibility call, so admins set it during triage and it carries over on promotion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
November 20, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 1 Skim 👀 view-only: funder-only checkbox gated to admins on the story idea form
Submitters no longer see the funder-only box — they could tick it alongside public-sharing permission, which contradict each other.
What is the goal of this PR and why is this important?
How did you approach the change?
allowed_to?(:manage?, StoryIdea), in an admin-only panel.Features seed (optional)
UI Testing Checklist
Anything else to add?
🤖 Generated with Claude Code