Conversation
Group implementations by backend and isolate platform-specific constants.
Keep platform constants reusable without initializing an FFI backend.
Use Darwin terminal ioctls because JRuby FFI corrupts terminal state when calling `tcgetattr` and `tcsetattr` on arm64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the JRuby implementation under
jruby/lib/io/consoleand separateconsole backends from platform constants. This makes the backend boundaries
explicit and keeps reusable constants independent from FFI initialization.
Support the FFI termios backend on arm64 Darwin. JRuby FFI does not reliably
preserve terminal state through
tcgetattrandtcsetattrthere, so Darwinuses the equivalent
TIOCGETAandTIOCSETAioctls.Validation:
jruby -S rake test