Repository navigation
build: derive version from git tags - #660
Closed
huong8373tt-beep wants to merge 1 commit into
Closed
huong8373tt-beep wants to merge 1 commit into
huong8373tt-beep wants to merge 1 commit into
Conversation
Signed-off-by: Slai.life <huong8373tt@gmail.com>
AkihiroSuda
reviewed
Nov 4, 2026
| // Version is set at build time from the repository tag. | ||
| // | ||
| // Keep a useful fallback for source archives that do not contain Git metadata. | ||
| var Version = "unknown" |
Member
There was a problem hiding this comment.
- "unknown" isn't useful
- This task is not actionable until v4. I'm planning to work on it myself
- You seem to be a fully automatic bot account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #631.
Summary
git describe --tags --always --dirty;unknownwhen building a source archive without Git metadata.Validation
go test ./pkg/version ./cmd/rootlesskit ./cmd/rootlessctl ./cmd/rootlesskit/unshare ./cmd/rootlesskit-docker-proxymake clean all VERSION=v4.0.0-test; verifiedrootlesskitandrootlessctlreport the injected version and--print-semver majorreturns4git describevalue.gitremoved builds with versionunknown;--print-semverreports the expected semantic-version parsing errorgit diff --checkSlai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.