Skip to content

Fix compile error in RowListFocusStyleTest (FloatFullScreen.xml) - #82

Open
rajashekharrangappa wants to merge 1 commit into
rokudev:masterfrom
rajashekharrangappa:fix/rowlist-floatfullscreen-compile-error
Open

Fix compile error in RowListFocusStyleTest (FloatFullScreen.xml)#82
rajashekharrangappa wants to merge 1 commit into
rokudev:masterfrom
rajashekharrangappa:fix/rowlist-floatfullscreen-compile-error

Conversation

@rajashekharrangappa

Copy link
Copy Markdown

Problem

The RowListFocusStyleTest sample fails to build. The BrightScript inside the <![CDATA[ ]]> block of FloatFullScreen.xml is collapsed onto a single physical line, with runs of spaces where the statement separators should be:

Sub init()                m.top.setFocus(true)                m.RowList = m.top.findNode("rowList")  ...  end Sub

BrightScript statements are newline-terminated, so the parser hits Sub init() m.top.setFocus(true) and stops:

------ Compiling dev 'RowList Node Focus Animation Style Test' ------

=================================================================
Found 1 compile error
--- Syntax Error. (compile error &h02) in pkg:/components/FloatFullScreen.xml(7)
*** ERROR compiling FloatFullScreen:

=================================================================
An error occurred while attempting to compile the application's components:
-------> Compilation Failed.
FloatFullScreen

Because the failure is at compile time, the entire channel fails to sideload — not just this one screen. The "FloatingFocus - Full screen width" entry listed in testListScene.xml can't be reached at all.

Fix

Restore the line breaks and indentation in the script block, matching the formatting already used by the sibling FloatCropToItems.xml.

No logic changes, and none of the RowList attributes (rowFocusAnimationStyle, focusXOffset, rowItemSize, etc.) were touched — this is purely the whitespace that the compiler needs.

Notes

  • The referenced nodes RowListContentTask and PosterItem both exist in the sample, so no other files needed changes.
  • I grepped the rest of the repo for the same collapsed-CDATA pattern; FloatFullScreen.xml was the only occurrence.
  • One incidental tidy-up in the same block: the task handle was referred to as both m.LoadTask and m.loadTask. BrightScript identifiers are case-insensitive so it worked either way, but it's now consistently m.LoadTask.

🤖 Generated with Claude Code

The BrightScript inside the CDATA block was collapsed onto a single
physical line, with spaces where statement separators belonged:

    Sub init()                m.top.setFocus(true)  ...  end Sub

BrightScript statements are newline-terminated, so the compiler failed
on FloatFullScreen.xml(7):

    Syntax Error. (compile error &h02) in pkg:/components/FloatFullScreen.xml(7)
    ***ERROR compiling FloatFullScreen:

This made the whole sample channel fail to build, so the
"FloatingFocus - Full screen width" entry in testListScene could not be
opened.

Restore the line breaks and indentation, matching the formatting of the
sibling FloatCropToItems.xml. No logic or RowList attributes changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants