Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated
make packagebuilds a fresh app but skips an existingpackage/Squirrel.pkg. With parallel make, packaging can also start before the release build finishes.Make the installer target depend on
releaseso it is rebuilt after a successful app build.Validation used the original and changed Makefiles with isolated build and packaging stubs. The original reproduced both failures; the change refreshed the installer on the second invocation, ordered parallel packaging after the build, ran the build once per invocation, and prevented packaging after a failed build. Full Xcode compilation and installer signing were not run locally.