Skip to content

fix: TCPKeepAliveAdapter does not setting TCP_KEEPALIVE (#391) - #407

Open
Sushant1-oops wants to merge 1 commit into
requests:mainfrom
Sushant1-oops:ai-fix/issue-391-988f01bd
Open

Sushant1-oops wants to merge 1 commit into
requests:mainfrom
Sushant1-oops:ai-fix/issue-391-988f01bd

Conversation

@Sushant1-oops

Copy link
Copy Markdown

AI-generated fix

Fix TCPKeepAliveAdapter on platforms like macOS Python 3.14 where TCP_KEEPINTVL is absent and the fallback branch incorrectly used elif instead of else, leaving TCP_KEEPINTVL unconfigured. Now the fallback branch correctly applies TCP_KEEPINTVL.

Fixes #391

Tests: passing (python -m pytest -x -q)

Files changed:

  • requests_toolbelt/adapters/socket_options.py

Generated by Issue Solver (MiniMax via OpenRouter, Gemini fallback).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TCPKeepAliveAdapter does not setting TCP_KEEPALIVE

1 participant