Repository navigation
Fix AuthHandler lookup and removal examples - #400
Closed
ryanduguid wants to merge 1 commit into
Closed
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
Construct the example handlers from mappings with full URLs so the strategy lookup and removal examples execute correctly.
Author
|
Closing this as part of a tidy-up of my open PRs. Happy to reopen or rebase it if it's still useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
AuthHandler.get_strategy_forandremove_strategyexamples, which pass a set to a constructor that expects a mapping. Include the scheme in each strategy key and use the matching URL when removing it.Evidence
ValueErrorduring construction.After: Both corrected examples execute successfully, alongside the existing
add_strategyexample and an HTTP/HTTPS mismatch control.Risk
Only docstring examples change.
Unverified
Full Tox fails: Python 3.9 has the same two X509 deprecation failures on master and on this branch, and Python 3.10 and 3.11 show those failures on this branch (their master runs were not done). Python 2.7, 3.7, 3.8 and PyPy were not run. macOS and upstream CI are unverified.