Skip to content

Include source_address when pickling SourceAddressAdapter - #395

Closed
gyanu2507 wants to merge 1 commit into
requests:mainfrom
gyanu2507:pickle-source-adapter
Closed

gyanu2507 wants to merge 1 commit into
requests:mainfrom
gyanu2507:pickle-source-adapter

Conversation

@gyanu2507

Copy link
Copy Markdown

HTTPAdapter only pickles __attrs__. SourceAddressAdapter never put source_address on that list, so unpickling a session that used it died in init_poolmanager. Same pattern SSLAdapter already uses.

Fixes #394.

HTTPAdapter only pickles __attrs__, so the bound address was dropped
and unpickling blew up in init_poolmanager.

Fixes #394.
@gyanu2507

Copy link
Copy Markdown
Author

Closing this to narrow my open-source work to fewer projects. Anyone is welcome to pick the change up if it's useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpickling a session with source adapter fails

1 participant