Skip to content

fix(tests): close radiogroup re-query race in fillRadio helper #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabrielseco merged 1 commit into from
Sep 14, 2026
Merged

fix(tests): close radiogroup re-query race in fillRadio helper #1312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 13 additions & 21 deletions src/tests/testHelpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,14 @@ export async function assertRadioValue(
radioName: string,
expectedValue: string,
) {
// Wait for the radio group to be available
await waitFor(() => {
const radioGroup = screen.getByRole('radiogroup', {
// Wait for the radio group to be available, keeping the resolved element
// instead of re-querying afterwards (which raced against the group
// briefly unmounting again, e.g. during a second async loading phase)
const radioGroup = await waitFor(() =>
screen.getByRole('radiogroup', {
name: new RegExp(radioName, 'i'),
});
expect(radioGroup).toBeInTheDocument();
});

// Get the radio group
const radioGroup = screen.getByRole('radiogroup', {
name: new RegExp(radioName, 'i'),
});
expect(radioGroup).toBeInTheDocument();
}),
);

// Find all radio buttons within the group
const radioButtons = within(radioGroup).getAllByRole('radio');
Expand All @@ -86,15 +81,12 @@ export async function assertRadioValue(
export async function fillRadio(radioName: string, radioValue: string) {
const user = userEvent.setup();

// Wait for the radio group to be available - use role-based query for specificity
await waitFor(() => {
screen.getByRole('radiogroup', { name: new RegExp(radioName, 'i') });
});

// Get the specific radiogroup by role (not just by text)
const radioGroup = screen.getByRole('radiogroup', {
name: new RegExp(radioName, 'i'),
});
// Wait for the radio group to be available, keeping the resolved element
// instead of re-querying afterwards (which raced against the group
// briefly unmounting again, e.g. during a second async loading phase)
const radioGroup = await waitFor(() =>
screen.getByRole('radiogroup', { name: new RegExp(radioName, 'i') }),
);

// Find the radio button within that group
const radioButton = within(radioGroup).getByRole('radio', {
Expand Down
Loading