Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 4de7a25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
stringifyConfiginpackages/react-router/src/bindings.tsx:25setsencode: false, sorouterProvider.gowrites query values into the URL raw. WhenuseTablesyncs filters with the location,routerProvider.parsereads them back changed:alice+amazon@gmail.combecomesalice amazon@gmail.com,Tom & JerrybecomesTom, andissue #42is cut at the hash. That happens after a reload, a shared link, or navigating back to the list.What is the new behavior?
Values are encoded (
encode: falseremoved).encodeValuesOnly: truekeeps keys such asfilters[0][value]readable. The manualencodeURIComponentof thetoparam is removed because qs now encodes it, sotokeeps exactly the same URL form as before (to=%2Fposts%3FcurrentPage%3D2, covered by a test).fixes #6659
Test: new
packages/react-router/src/bindings.test.tsx, using the realrouterProvider.go+parseinside aMemoryRouter.main@2352eb5b: 4 failed (plus sign, ampersand, hash, readable path/to), 20 passedNotes for reviewers
stringifyConfigis exported, so code that reuses it now gets encoded values. That is the intended fix.nextjs-router(app and pages),remix-routerand corestringifyTableParamsalso useencode: false. I kept this PR to react-router so it stays small, and I'm happy to follow up with the others.