Repository navigation
fix(simple-rest): pass body and headers correctly in deleteOne method override - #7614
Open
irongopher75 wants to merge 1 commit into
Open
irongopher75 wants to merge 1 commit into
irongopher75 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 1dc11a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
deleteOnein@refinedev/simple-restalways calls:This is correct for axios
delete, where the second argument is the request config. But the docs saymeta.methodcan override the HTTP method. Whenmeta.methodis"post","put"or"patch", axios treats the second argument as the request body, so:meta.headers(for exampleAuthorization) are not sent, and{"data": variables, "headers": {...}}instead ofvariables.What is the new behavior?
post,putandpatch,deleteOnenow callshttpClient[method](url, variables, { headers }). The body isvariablesand the headers are applied.deleteby default, plusget/head/options), the call is unchanged:httpClient[method](url, { data: variables, headers }). Default behaviour (plainDELETE) is the same as before.MethodTypes | MethodTypesWithBody, and the branching uses the sameswitchstyle ascustomin the same file.documentation/docs/guides-concepts/data-fetching/data-provider-interface.md. Versioned docs are not changed.Tests added in
packages/simple-rest/test/deleteOne/(nock, following the existing mock style):deleteOnesendsDELETEwithvariablesas the body andmeta.headersapplied.meta: { method: "post" | "put" | "patch", headers: { "x-custom": "1" } }sends that method with the body equal tovariables(not wrapped) and the custom header present.The post/put/patch tests fail on
main(nock reports no match: the request has nox-customheader and a wrapped body) and pass with this change.pnpm test -- --scope @refinedev/simple-restpasses (30/30), and biome reports no issues.Resolves #7613
Notes for reviewers
Only body-carrying overrides change. The default
DELETEpath is unchanged.