Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 96a4ce5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
The validation matrix looks comprehensive—especially the direct Node 20/22 runtime checks and attw verification.
Marking this as a patch changeset is appropriate since the public API and serialization behavior remain completely unchanged
Author
|
@codeCraft-Ritik is there anything I need to do? If yes, let me know. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Bugs / Features
simple-restsuite covers the unchanged query serialization behaviorWhat is the current behavior?
@refinedev/simple-rest@6.0.1depends onquery-string@^7.1.1, which installsdecode-uri-component@0.2.2. That version is affected by CVE-2026-45822 / GHSA-vcc3-ghjq-m6fr.A direct override to
decode-uri-component@0.5.0is not compatible withquery-string@7. The current securequery-stringrelease is ESM-only, while@refinedev/simple-restsupports both ESM and CommonJS consumers.What is the new behavior?
query-stringto^9.5.1, which usesdecode-uri-component@0.5.0.stringifyAPI.simple-restoutputs, preserving CommonJS support.Fixes #7601.
Notes for reviewers
Validated with:
pnpm --filter @refinedev/simple-rest test— 26 tests pass@refinedev/simple-rest— passes, including declarationspublint— passes with the existingtypefield suggestionattw --pack .— no problems for Node 10, Node 16 CJS/ESM, or bundlersAdvisory: GHSA-vcc3-ghjq-m6fr