vm: log verification results for dirty_* options

[dwivedipranav-dev]

Summary

• tuned-adm verify can fail when [vm] dirty_* options do not match the running sysctls, but _dirty_option() never logged the mismatch.
• Route verify through _verify_value() so /var/log/tuned/tuned.log contains verify: failed: / verify: passed: like other plugins.
  Resolves: RHEL-212716

Test plan

• Apply a child profile that inherits throughput-performance and sets vm.dirty_bytes / vm.dirty_background_bytes under [sysctl] without overriding the parent [vm] ratios.
• tuned-adm verify still fails, and the log now has verify: failed: for dirty_ratio / dirty_background_ratio.
• Override [vm] dirty_ratio=0 and dirty_background_ratio=0, then confirm verify succeeds and the log has verify: passed:.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fab439c4-813a-4a5d-8da4-035c2810f194

📥 Commits

Reviewing files that changed from the base of the PR and between 2bfa442 and 97778ea.

📒 Files selected for processing (1)

• tuned/plugins/plugin_vm.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved validation of requested option values to ensure changes are checked consistently against the current setting.

Walkthrough

The VM plugin replaces direct value comparison in _dirty_option with a call to _verify_value.

Changes

VM option verification

Layer / File(s)	Summary
Delegate value verification tuned/plugins/plugin_vm.py	_dirty_option now delegates verification to _verify_value with the option, requested value, current value, and False flag.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 97778

The change makes dirty_* verification mismatches appear in the verification log without altering verification outcomes; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description accurately explains the verification logging change and provides a related test plan.
Title check	✅ Passed	The title clearly identifies the VM dirty option verification logging change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[yarda]

Thanks, LGTM. The CentOS 7 failure is unrelated. It will go into TuneD 2.29.0.

[dwivedipranav-dev]

Dear @yarda

Thanks for the review. I’ll treat the CentOS 7 failure as unrelated. Happy to make any follow-up changes if you need anything else from my side.

[dwivedipranav-dev]

Hello @yarda

Any update on this PR please

[dwivedipranav-dev]

@yarda any update on the PR please ?

[dwivedipranav-dev]

@yarda hi any update please ?

[dwivedipranav-dev]

@yarda hi any update please ?