cherry-pick of tag sync job fixes: empty bucket read - #170
Merged
Merged
Conversation
The shared Cassandra query helper drops read errors, so a failed read looked like an empty result. Tag sync aborted the whole run with cassandra_suspect_empty_bucket when a bucket listed in TagBucketMetadata read as empty, and other failed reads silently skipped tags or buckets. Tagging reads now go through queryRows, which returns read errors. A failed read aborts the sync with cassandra_error and the driver message; a bucket that really is empty is skipped, counted in emptyBuckets and logged. Tag API reads return an error instead of partial or empty results when Cassandra fails.
…rror handling and code clarity
GET /taggingService/tags/sync/status/{runId} returns one run record, so a
caller can poll a run without reading the whole history. 404 when the id is
not in the retained history; store errors are sanitized like /sync/status.
A failed read stored "cassandra_error: <driver error>" as the abort reason, which the status endpoints return to clients; driver errors can name hosts and keyspaces. The reason is now just cassandra_error and the driver error is logged under the run's audit_id.
queryRows now returns read errors instead of dropping them, and the tag APIs write errors into the response body, so a Cassandra outage could expose hosts and keyspaces. queryRows now logs the driver error with the query text and returns a generic "tag store read failed" error.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Some member-read paths still convert Cassandra failures into 404 or incomplete successful responses.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Improves tag-sync reliability by distinguishing Cassandra failures from genuinely empty buckets and adds per-run status polling.
Changes:
- Propagates and sanitizes Cassandra read errors.
- Skips and counts stale empty buckets.
- Adds a run-specific status endpoint and documentation.
| File | Description |
|---|---|
taggingapi/tag/tag_sync.go |
Handles empty buckets and sanitized abort reasons. |
taggingapi/tag/tag_sync_test.go |
Tests error handling and empty buckets. |
taggingapi/tag/tag_sync_state.go |
Uses error-aware state reads. |
taggingapi/tag/tag_sync_handler.go |
Adds sanitized status-loading and run lookup. |
taggingapi/tag/tag_sync_handler_test.go |
Tests missing run IDs. |
taggingapi/tag/tag_member_service.go |
Adopts error-aware tag-store reads. |
taggingapi/tag/query_rows.go |
Implements error-aware Cassandra queries. |
taggingapi/tag/query_rows_test.go |
Tests read-error sanitization. |
taggingapi/router.go |
Registers run-specific status route. |
contrib/docs/tagging_service_API_documentation.md |
Documents status and empty-bucket behavior. |
common/const_var.go |
Defines the run ID route key. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
coolwater
approved these changes
Oct 2, 2026
coolwater
left a comment
coolwater
left a comment
There was a problem hiding this comment.
Approved. ✅
Reviewed the changes and did not find any blocking issues. The update improves tag sync resilience by correctly distinguishing stale/empty buckets from Cassandra read failures, adds good coverage around run status retrieval and error sanitization, and supports safer operational use of tag refresh workflows. The logic and tests look consistent with the intended behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.