Run cleanup functions on before-cache - #1360
Merged
Merged
Conversation
Jade-GG
approved these changes
Aug 18, 2026
Collaborator
|
How much value is there still to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Vue 3 functionality regarding unmounting has changed with useEventListener.
This results in the cleanup function only being called for
useEventListenercalls done within a .vue component.This caused e.g. addToCart listeners of the gtm package to start stacking the same event listener.
Luckily
useEventListeneralso returns the cleanup function, we unmount Vue onturbo:before-cacheso we can cleanup the listeners ourselves.Ref: FW-2481