docs: use the SPDX identifier for the licence in README - #115
Conversation
README's License section wrote "DecentraLicense 1.0 (DCL-1.0)". `DCL-1.0` is not a valid SPDX identifier for this licence; `LicenseRef-DCL-1.0` is, and is what every SPDX header, REUSE.toml, foundry.toml, the LICENSE symlink target and CLAUDE.md's parallel License section already use. README was the only bare occurrence, and the one a consumer could copy into their own headers where `reuse lint` would fail on it. Closes #69 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 15 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed f6cdc67: ready — Closes #69. One line. CI green, 0 unresolved threads — vacuous, CodeRabbit reports |
Closes #69
Audit finding
D3-07(dimension 3, INFO).README's License section wrote the licence as
DecentraLicense 1.0 (DCL-1.0).DCL-1.0is not a valid SPDX identifier for this licence — the repo'sidentifier is
LicenseRef-DCL-1.0everywhere it is actually load-bearing(every
src/**andtest/**SPDX header,REUSE.toml,foundry.toml, theLICENSEsymlink target) and in CLAUDE.md's own parallel License section.README was the one place stating a form a consumer could copy into their own
headers, where
reuse lintwould then fail on it.The expansion "DecentraLicense 1.0" was already correct — the licence file's
own first heading is
# DecentraLicense— so only the parenthetical changes:SPDX:labels it as the identifier rather than an abbreviation, which is thedistinction that was missing — the whole defect was that a bare parenthetical
reads as "here is the short name you may use".
Verification
DCL-1.0(excludingdependencies/,out/,cache/,.git/) now returns zero bare occurrences: every remaining hit isLicenseRef-DCL-1.0. README.md:364 was the only one.CAL-1.0on line 365 is untouched and correct — that IS a validSPDX identifier, for the unrelated licence it compares against.
README prose (
rainix-sol-legalrunsreuse lint, which checks SPDXheaders and
REUSE.toml), and no test intest/asserts on README text —which is why the divergence survived in the first place.
QA
the repo asserts on README text, and adding a README-prose linter is a
different change than the one the issue asks for. The issue's own
verification block establishes the same thing:
reuse lintcovers SPDXheaders and
REUSE.toml, not prose, and no test intest/reads README.The equivalent check for a text change is exhaustiveness, and that was run:
repo-wide
grep -rn "DCL-1\.0"excludingdependencies/,out/,cache/,.git/now returns zero hits that are notLicenseRef-DCL-1.0(exit 1, nomatches). Stated plainly: grep-zero is not mutation coverage, it is proof
the string is gone.
LicenseRef-prefix for a licence not on the SPDX list; the licence file's own first
heading (
LICENSES/LicenseRef-DCL-1.0.txt:1) is# DecentraLicense,confirming the expansion; and
REUSE.toml,foundry.toml, theLICENSEsymlink target and every
src/**/test/**SPDX header independentlyspell the identifier as
LicenseRef-DCL-1.0. README was measured againstthose, not against itself.
not the identifier used everywhere else — and gives the exact replacement
text. Covered exactly. Widened past the single cited line to the whole repo
by grep to confirm README.md:364 really was the only instance of the
category, rather than fixing only the example the issue named; it was.