Repository navigation
Apply Netty configuration changes to subsequent connections (backport #2133) - #2134
Merged
Merged
Conversation
Author
|
Cherry-pick of 8e3ac43 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
The Netty frame handler factory was created on the first connection and cached for the lifetime of the connection factory. Any later change to the Netty configuration (TLS context, event loop group, customizers, enqueuing timeout) or to the connection timeout, socket configurator, and recovery settings was silently ignored for new connections. This is inconsistent with the blocking IO transport. The Netty frame handler factory is now created for each connection, like the blocking IO one. Existing connections, including their recovery, keep using the factory they were created with. ConnectionFactory#clone() also shared the Netty configuration with the original factory. The clone now gets its own copy. (cherry picked from commit 8e3ac43) # Conflicts: # src/main/java/com/rabbitmq/client/ConnectionFactory.java # src/test/java/com/rabbitmq/client/test/ConnectionFactoryTest.java
acogoluegnes
force-pushed
the
mergify/bp/v5.x/pr-2133
branch
from
October 19, 2026 08:56
729bb0a to
ae77f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Netty frame handler factory was created on the first connection and cached for the lifetime of the connection factory. Any later change to the Netty configuration (TLS context, event loop group, customizers, enqueuing timeout) or to the connection timeout, socket configurator, and recovery settings was silently ignored for new connections. This is inconsistent with the blocking IO transport.
The Netty frame handler factory is now created for each connection, like the blocking IO one. Existing connections, including their recovery, keep using the factory they were created with.
ConnectionFactory#clone() also shared the Netty configuration with the original factory. The clone now gets its own copy.
This is an automatic backport of pull request #2133 done by [Mergify](https://mergify.com).