Simplified heat sliders buildings - #3469
Conversation
| # Priority is set to 1 to go after number of buildings but before behaviour sliders. | ||
|
|
||
| - query = | ||
| relative_change = DIVIDE(100 + USER_INPUT(), 100); |
There was a problem hiding this comment.
It is good practice to use 100.0 in calculations like these. I think this ensures the engine will read it as a float instead of an integer.
| UPDATE_WITH_FACTOR(V(buildings_useful_demand_for_space_heating_buildings_present), preset_demand, relative_change), | ||
| UPDATE_WITH_FACTOR(V(buildings_useful_demand_for_space_heating_buildings_future), preset_demand, relative_change) | ||
| ) | ||
| - priority = 0 |
There was a problem hiding this comment.
How does this relate to the flexibility_outdoor_temperature input that also sets the buildings heat demand with a factor and priority 0?
UPDATE_WITH_FACTOR(V(buildings_useful_demand_for_space_heating_buildings_present), preset_demand, heat_factor),
UPDATE_WITH_FACTOR(V(buildings_useful_demand_for_space_heating_buildings_future), preset_demand, heat_factor),
UPDATE_WITH_FACTOR(V(buildings_useful_demand_cooling), preset_demand, cool_factor),
UPDATE_WITH_FACTOR(V(agriculture_useful_demand_useable_heat), preset_demand, heat_factor)
)
},
-> {},
)
- priority = 0
Also, changed priorities to accomodate for settings_weather_curves_set.ac
76f8937 to
e876035
Compare
There was a problem hiding this comment.
The other development of demand sliders are set with a percentage per year change. What do we think is appropriate @kndehaan?
There was a problem hiding this comment.
We want to keep it as a %, but to separate it clearly from the other sliders it should have its own group header.
|
Done, with the review. All in all nice work! There are some points of discussion left. To final points:
|


Context
This PR simplifies the input sliders for the buildings.
Implemented changes
Related
Goes with pull requests:
Checklist