Repository navigation
Conversation
go-que v1.2.0 fixes the mutex getting stuck in "bad mutex" after a connection error, and go-bus v0.2.0 moves quex onto go-que's supervisor. goquex keeps building unchanged: quex.WorkerController is now an alias of supervisor.WorkerController.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pgx upgrade breaks gormx.OpenContainer for passwords containing @ because URL userinfo is not escaped, requiring proper encoding and a regression test.
1 open issue
What changed in this PR
Updates x’s dependency minimums to bring downstream users the go-que connection-error recovery fix and go-bus’s supervisor integration.
Changes:
- Bumps go-bus to v0.2.0 and go-que to v1.2.0.
- Updates pgx, OpenTelemetry, and related dependencies, including the documented pgx connection-string parsing change.
- Refreshes checksums without changing application code or the Go directive.
| File | Description |
|---|---|
| go.sum | Updates dependency checksums and removes obsolete entries. |
| go.mod | Raises queue, bus, and related dependency versions. |
Review effort: Balanced
| github.com/huandu/go-clone/generic v1.7.3 | ||
| github.com/iancoleman/strcase v0.3.0 | ||
| github.com/jackc/pgx/v5 v5.9.2 | ||
| github.com/jackc/pgx/v5 v5.12.0 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
go-que v1.1.x can leave its pg mutex stuck in
bad mutexafter a connection error (e.g. Aurora zero-downtime patching drops the session), and workers started through go-bus'squexthen never recover. go-que v1.2.0 fixes that and go-bus v0.2.0 movesquexonto go-que's newsupervisorpackage.x's go.mod is a minimum for everyone using x, so bumping here means projects that only get go-bus/go-que through x pick up the fix too.
What changes
github.com/qor5/go-busv0.1.2 → v0.2.0github.com/qor5/go-quev1.1.0 → v1.2.0jackc/pgx/v55.9.2 → 5.12.0, otel 1.44 → 1.45,klauspost/compress,puddle,logr(patch/minor)godirective is unchanged.No code changes.
goquex.WorkerServicestill takesquex.WorkerController, which in go-bus v0.2.0 is a type alias ofsupervisor.WorkerController, so existing callers keep compiling and can also pass asupervisorcontroller directly.Heads-up for downstream
pgx 5.10+ parses connection strings the libpq way. A URL with an unescaped
@in the password, likepostgres://app:p@ss@db.example.com/db, now fails (host becomesss@db.example.com). Escape it as%40. This comes with go-bus v0.2.0 anyway; it's listed here because bumping x makes it reach x's users.Checked
go build ./...,go vet ./...go test ./gobusx/... ./goquex/... ./gormx/...(postgres via testcontainers)