Skip to content

Bump go-bus to v0.2.0 and go-que to v1.2.0 - #674

Open
molon wants to merge 1 commit into
masterfrom
molon/bump-go-bus-v0.2.0
Open

molon wants to merge 1 commit into
masterfrom
molon/bump-go-bus-v0.2.0

Conversation

@molon

@molon molon commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Why

go-que v1.1.x can leave its pg mutex stuck in bad mutex after a connection error (e.g. Aurora zero-downtime patching drops the session), and workers started through go-bus's quex then never recover. go-que v1.2.0 fixes that and go-bus v0.2.0 moves quex onto go-que's new supervisor package.

x's go.mod is a minimum for everyone using x, so bumping here means projects that only get go-bus/go-que through x pick up the fix too.

What changes

  • github.com/qor5/go-bus v0.1.2 → v0.2.0
  • github.com/qor5/go-que v1.1.0 → v1.2.0
  • Pulled up along with them: jackc/pgx/v5 5.9.2 → 5.12.0, otel 1.44 → 1.45, klauspost/compress, puddle, logr (patch/minor)
  • The go directive is unchanged.

No code changes. goquex.WorkerService still takes quex.WorkerController, which in go-bus v0.2.0 is a type alias of supervisor.WorkerController, so existing callers keep compiling and can also pass a supervisor controller directly.

Heads-up for downstream

pgx 5.10+ parses connection strings the libpq way. A URL with an unescaped @ in the password, like postgres://app:p@ss@db.example.com/db, now fails (host becomes ss@db.example.com). Escape it as %40. This comes with go-bus v0.2.0 anyway; it's listed here because bumping x makes it reach x's users.

Checked

  • go build ./..., go vet ./...
  • go test ./gobusx/... ./goquex/... ./gormx/... (postgres via testcontainers)

go-que v1.2.0 fixes the mutex getting stuck in "bad mutex" after a
connection error, and go-bus v0.2.0 moves quex onto go-que's supervisor.
goquex keeps building unchanged: quex.WorkerController is now an alias of
supervisor.WorkerController.
Copilot AI balanced review requested due to automatic review settings November 11, 2026 09:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pgx upgrade breaks gormx.OpenContainer for passwords containing @ because URL userinfo is not escaped, requiring proper encoding and a regression test.

1 open issue
What changed in this PR

Updates x’s dependency minimums to bring downstream users the go-que connection-error recovery fix and go-bus’s supervisor integration.

Changes:

  • Bumps go-bus to v0.2.0 and go-que to v1.2.0.
  • Updates pgx, OpenTelemetry, and related dependencies, including the documented pgx connection-string parsing change.
  • Refreshes checksums without changing application code or the Go directive.
File Description
go.sum Updates dependency checksums and removes obsolete entries.
go.mod Raises queue, bus, and related dependency versions.

Review effort: Balanced

Comment thread go.mod
github.com/huandu/go-clone/generic v1.7.3
github.com/iancoleman/strcase v0.3.0
github.com/jackc/pgx/v5 v5.9.2
github.com/jackc/pgx/v5 v5.12.0

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants