Skip to content

Update sampling_compound_step notebook to PyMC v6 and ArviZ v1 - #905

Merged
jessegrabowski merged 5 commits into
pymc-devs:mainfrom
jessegrabowski:update-sampling-compound-step
Nov 13, 2026
Merged

jessegrabowski merged 5 commits into
pymc-devs:mainfrom
jessegrabowski:update-sampling-compound-step

Conversation

@jessegrabowski

Copy link
Copy Markdown
Member

Updated samplers/sampling_compound_step.ipynb to run on PyMC v6 and ArviZ v1, and corrected its descriptions of step assignment, step order, and the accept sample stat.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -9,7 +9,15 @@
}

@aloctavodia aloctavodia Oct 26, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #6.        trace = pm.sample(10000)

we could use default number of draws, the same for other calls


Reply via ReviewNB

@@ -9,7 +9,15 @@
}

@aloctavodia aloctavodia Oct 26, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    az.plot_dist(accept_prob1);


Reply via ReviewNB

@@ -9,7 +9,15 @@
}

@aloctavodia aloctavodia Oct 26, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    az.plot_dist(accept_prob2);


Reply via ReviewNB

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this and the one above have a comment eaten? They're blank

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am suggesting to use az.plot_dist(accept_prob1) and az.plot_dist(accept_prob2)

@@ -9,7 +9,15 @@
}

@aloctavodia aloctavodia Oct 26, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover, or is this supposed to be integrated into the example?


Reply via ReviewNB

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cell generates the graph for the thumbnail. It's hidden with a metadata tag so it doesn't appear in the myst.md rendering of the notebook on the examples site.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh... ok

@jessegrabowski
jessegrabowski merged commit ab4b347 into pymc-devs:main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants