Repository navigation
register_status_bindings: Remove redundant ABSL_USES_STD_STRING_VIEW check - #84
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1012946620
branch
from
November 9, 2026 15:07
caf9aa5 to
6375c48
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_1012946620
branch
from
November 9, 2026 15:20
6375c48 to
fa44905
Compare
copybara-service
Bot
force-pushed
the
test_1012946620
branch
2 times, most recently
from
November 9, 2026 15:45
69fc4dd to
21646f9
Compare
…check Abseil requires C++17 and `absl::string_view` is unconditionally an alias for `std::string_view` (`ABSL_USES_STD_STRING_VIEW` is always `1`), making `#ifdef ABSL_USES_STD_STRING_VIEW` and `#ifndef ABSL_USES_STD_STRING_VIEW` checks unnecessary: * abseil/abseil-cpp@7a03cdb ("Require C++17") * abseil/abseil-cpp@9ebd93a ("Remove the implementation of `absl::string_view`") pybind11_abseil builds against Abseil 20260107.1, the first LTS without the `absl::string_view` implementation, since b2a99bc725b6 ("bazel, cmake: Update Abseil to 20260107.1"). PiperOrigin-RevId: 1017342067
copybara-service
Bot
force-pushed
the
test_1012946620
branch
from
November 9, 2026 15:48
21646f9 to
d716e21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_status_bindings: Remove redundant ABSL_USES_STD_STRING_VIEW check
Abseil requires C++17 and
absl::string_viewis unconditionally an aliasfor
std::string_view(ABSL_USES_STD_STRING_VIEWis always1), making#ifdef ABSL_USES_STD_STRING_VIEWand#ifndef ABSL_USES_STD_STRING_VIEWchecks unnecessary:
("Require C++17")
("Remove the implementation of
absl::string_view")pybind11_abseil builds against Abseil 20260107.1, the first LTS without
the
absl::string_viewimplementation, sinceb2a99bc725b6
("bazel, cmake: Update Abseil to 20260107.1").