Repository navigation
fix: serialize booleans as lowercase keywords in create_dictionary_string - #1973
Merged
andersonhc merged 1 commit intoSep 29, 2026
Merged
Conversation
andersonhc
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
create_dictionary_string()(fpdf/syntax.py), dictionary entries are serialized by stringifying keys and values:When a dictionary contains native Python boolean values (
TrueorFalse), calling rawstr(v)produces uppercaseTrueorFalse(e.g.<</Marked True>>), andhas_empty_fields=Trueinadvertently strippedFalseand0due toif v.This violates the PDF 1.7 / 2.0 specification (ISO 32000-1 § 7.3.2: boolean objects must be written as the lowercase keywords
trueandfalse).This fix:
str(v).lower()increate_dictionary_string(), ensuring strict compliance with ISO 32000-1 § 7.3.2.clear_empty_fields()preserves significant falsy values (Falseand numeric0) while filtering outNoneand empty values.test/test_syntax.pywith parameterized test coverage for boolean dictionary serialization.