feat(settings): hide advanced settings by default - #39
Open
enricobuehler wants to merge 1 commit into
Open
enricobuehler wants to merge 1 commit into
enricobuehler wants to merge 1 commit into
Conversation
Every other client now hides its advanced rows until Show advanced is on, types a custom resolution, shows a one-line exit hint at stream start and places and sizes its statistics by the shared keys. The browser had none of these. Each tab lists its advanced rows last, under Show advanced, and says how many hidden rows hold a changed value. Display gains Aspect ratio and Custom… over the shared sizes and the typed-size rule, a TypeScript twin of punktfunk-core's with its vectors. The HUD draws the exit hint and the statistics card in the chosen corner and size. The pin moves to punktfunk 1184f7371, which carries the console tier. Core no longer exports index_gap, so recovery.rs reads the gap itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser's share of the settings overhaul, punktfunk unom/punktfunk#1594.
What changes
resolutions.ts, a TypeScript twin ofpunktfunk_core::resolutions, tested againstcustom-resolution-vectors.json's cases. Frame rate is Refresh rate; the fixed-bitrate slider reaches the 200 Mbps the store allows.hudPlacement,statsScalePct,exitHint,showAdvanced, each sanitised to the values every client stores.1184f7371. Core no longer exportsreanchor::index_gap, sorecovery.rsreads the gap itself (same half-space rule).Verification
npm run check,npm test(35 passed), Storybook build, release wasm + library + app builds.packages/stream:cargo fmt --check, native and wasm clippy-D warnings,cargo test(18 passed).