Skip to content

feat(settings): hide advanced settings by default - #39

Open
enricobuehler wants to merge 1 commit into
mainfrom
feat/settings-overhaul
Open

enricobuehler wants to merge 1 commit into
mainfrom
feat/settings-overhaul

Conversation

@enricobuehler

Copy link
Copy Markdown
Contributor

The browser's share of the settings overhaul, punktfunk unom/punktfunk#1594.

What changes

  • Settings: each tab lists its advanced rows last, under Show advanced at the end of General; with it off, a tab whose hidden rows hold changed values says how many, and Show lists them. Advanced here: Advanced statistics, Statistics position, Statistics size, Exit hint, Video codec, Video plane. Stick deadzone stays a basic row, since the Controllers tab has nothing else.
  • Display: Aspect ratio over the shared sizes, then Custom… with a typed width and height through the shared rule — resolutions.ts, a TypeScript twin of punktfunk_core::resolutions, tested against custom-resolution-vectors.json's cases. Frame rate is Refresh rate; the fixed-bitrate slider reaches the 200 Mbps the store allows.
  • Stream: a one-line exit hint for six seconds — the controller chord with a pad connected, Menu on a touchscreen, Ctrl+Alt+Shift+D otherwise — and the statistics in the chosen corner and size.
  • Store: hudPlacement, statsScalePct, exitHint, showAdvanced, each sanitised to the values every client stores.
  • Pin to punktfunk 1184f7371. Core no longer exports reanchor::index_gap, so recovery.rs reads the gap itself (same half-space rule).

Verification

  • npm run check, npm test (35 passed), Storybook build, release wasm + library + app builds.
  • packages/stream: cargo fmt --check, native and wasm clippy -D warnings, cargo test (18 passed).
  • Headless Chromium over the Storybook screens: 14 checks (tier hide/show, the changed count, Custom… clamping a typed odd width, the exit hint, the statistics corner, no sideways scroll at 390 px), no page errors.
  • Nothing on glass yet. Console mode shows none of the new rows: it reads only resolution, refresh rate and bitrate.

Every other client now hides its advanced rows until Show advanced is
on, types a custom resolution, shows a one-line exit hint at stream
start and places and sizes its statistics by the shared keys. The
browser had none of these.

Each tab lists its advanced rows last, under Show advanced, and says
how many hidden rows hold a changed value. Display gains Aspect ratio
and Custom… over the shared sizes and the typed-size rule, a
TypeScript twin of punktfunk-core's with its vectors. The HUD draws
the exit hint and the statistics card in the chosen corner and size.

The pin moves to punktfunk 1184f7371, which carries the console tier.
Core no longer exports index_gap, so recovery.rs reads the gap itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant