Repository navigation
Conversation
The Windows named pipe code in Pipes.cpp was compiled but never used: USE_PIPES was only defined on Unix, a holdover from when Windows built with MSBuild (Ishiiruka sets USE_PIPES in Base.props). Define it on the same platforms that compile Pipes.cpp. On Windows all four slippibot pipes always exist, so in blocking mode UpdateInput would wait forever for a FLUSH on pipes that no bot is connected to. Only wait on pipes with a connected client, polling with PeekNamedPipe since named pipes don't support select. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vladfi1
changed the title
vladfi1
marked this pull request as ready for review
October 24, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bots that play through the pipe controller inputs (e.g. libmelee) currently work with Ishiiruka on Windows but not with mainline.
Changes
USE_PIPESon Windows.Pipes.cpp(including its Windows named pipe code) is already compiled underif(UNIX OR WIN32)inInputCommon/CMakeLists.txt, butUSE_PIPESwas only definedif(UNIX), so the backend was never registered. Ishiiruka definesUSE_PIPESfor all Windows builds inBase.props; this looks like it was lost in the move to CMake.slippibotpipes always exist. WithBlockingPipes,UpdateInputwaits for aFLUSHon every pipe device, so it hung forever on pipes no bot had connected to. (Ishiiruka avoided this because aFLUSHclearedg_needInputForFramefor all devices.)waitForInputnow polls withPeekNamedPipeand gives up if no client is connected, which matches Unix, where a FIFO with no writer doesn't blockselect.Testing
Windows 11, Release build via CMake/Ninja (as in CI), using libmelee with blocking inputs:
🤖 Generated with Claude Code