Repository navigation
fix(overflow): clear a clipped item snapshot on unsubscribe - #8799
Open
nemo-crypto wants to merge 1 commit into
Open
nemo-crypto wants to merge 1 commit into
nemo-crypto wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The overflow hook retained the last clipped snapshot after unsubscribing. Re-enabling observation temporarily reused that old measurement. Clear it during unsubscribe and wait for the current observer to report its result.
Verification
The Chromium regression disables and re-enables a clipped item and checks the result before and after a new observer notification. The overflow hook suite passed (5 tests).