Skip to content

Warn about the integration skip workaround for fork pull requests - #8783

Merged
adierkens merged 4 commits into
mainfrom
adierkens-fork-integration-skip-status
Nov 17, 2026
Merged

adierkens merged 4 commits into
mainfrom
adierkens-fork-integration-skip-status

Conversation

@adierkens

@adierkens adierkens commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

N/A

Fork pull_request workflows cannot access the app secret used for skip statuses. Add a non-failing warning and job summary pointing maintainers to .skip-integration-checks, keeping the baseline on: configuration and existing execution paths unchanged.

Changelog

New

  • Static fork-only warning and summary before token creation; the warning itself does not fail the job.

Changed

N/A

Removed

N/A

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

Passed: actionlint -shellcheck= -pyflakes= .github/workflows/status-checks.yml, prettier --check .github/workflows/status-checks.yml, git diff --check, and node (inline YAML, exact-baseline, five guard, warning/summary and exit-0 assertions); hosted validation awaits deployment; UI builds/tests not run (workflow-only).

The existing token step can still fail on forks; this change adds guidance, not secret access or a successful status override. No status mutations or workflow dispatches were used for validation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@adierkens adierkens added the skip changeset This change does not need a changelog label Nov 17, 2026
@changeset-bot

changeset-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f9f856e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Restore pull_request events and fail before token creation with actionable fork guidance.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@adierkens adierkens changed the title Fix integration skip statuses for fork pull requests Explain integration skip workaround for fork pull requests Nov 17, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@adierkens adierkens changed the title Explain integration skip workaround for fork pull requests Fix fork integration skip statuses with maintainer guidance Nov 17, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@adierkens adierkens changed the title Fix fork integration skip statuses with maintainer guidance Warn about the integration skip workaround for fork pull requests Nov 17, 2026
@github-actions
github-actions Bot requested a deployment to storybook-preview-8783 November 17, 2026 15:58 Abandoned
@adierkens adierkens added the integration-tests: skipped manually Changes in this PR do not require an integration test label Nov 17, 2026
@adierkens
adierkens marked this pull request as ready for review November 17, 2026 15:59
@adierkens
adierkens requested a review from a team as a code owner November 17, 2026 15:59
@adierkens
adierkens requested review from TylerJDev and a balanced review from Copilot November 17, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The fork-PR guidance update has no active review issues.

No open issues 🎉

What changed in this PR

Adds guidance for maintainers when fork pull requests cannot access the app secret needed to set integration-skip statuses.

Changes:

  • Adds a fork-only warning and job summary before token creation, directing maintainers to comment .skip-integration-checks.
  • Preserves existing triggers and execution paths. The warning does not fail the job, but token creation can still fail.
File Description
.github/​workflows/​status-checks.yml Adds a fork-only warning and summary explaining the integration-skip workaround.

Review effort: Balanced

@adierkens
adierkens added this pull request to the merge queue Nov 17, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8783 November 17, 2026 16:10 Inactive
Merged via the queue into main with commit a09232e Nov 17, 2026
64 checks passed
@adierkens
adierkens deleted the adierkens-fork-integration-skip-status branch November 17, 2026 16:14

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-8783 — f9f856eb Deployed Nov 17, 2026 by github-actions[bot]
github-pages — f9f856eb Deployed Nov 17, 2026 by adierkens via deploy-preview #34389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants