Repository navigation
Conversation
memo() returned a component without the Symbol.for('react.memo')
marker React sets, so libraries like react-is could not recognise
Preact memo components (forwardRef already sets its own marker).
isMemo() worked around the missing marker with a displayName prefix
check, which also false-positived on any component merely named
Memo(...). Set the marker on memo components and detect it in
isMemo() instead.
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
43418typeof = Symbol.for('react.memo')tomemo(), matching React and Preact's ownforwardRef, so libraries likereact-iscan recognise Preact memo components.isMemo()now checks43418typeofinstead of the fragiledisplayName.startsWith('Memo(')heuristic, which misclassified any plain component withdisplayName = 'Memo(Foo)'as a memo component.Tests:
43418typeoftest formemo()and a misclassification regression test forisMemo(); both fail on the old code and pass with the fixforwardReftest case (implementation already existed and passes)Opening as a draft for community discussion, per CONTRIBUTING.