Skip to content

fix: highlight search matches in GTI's dropped columns, and keep a cell's blocks apart - #1177

Merged
rich-iannone merged 5 commits into
mainfrom
gti-search-highlights
Nov 18, 2026
Merged

rich-iannone merged 5 commits into
mainfrom
gti-search-highlights

Conversation

@rich-iannone

Copy link
Copy Markdown
Member

This PR fixes two problems with GTI's search highlights. A match ending on a letter followed by a separate combining accent now highlights the accent too, and text in separate blocks or lines of a cell (like two <div>s or a <br>) is kept apart by a space, so a match no longer runs across them.

In tables that drop columns to fit, the dropped columns' values shown under an open row now get the search's and text filters' highlights, which are redone as the search changes. The highlight loop is written so that Panel's Sucrase compile, which mangles for (… of (x) ?? []), still accepts the bundle.

@rich-iannone
rich-iannone merged commit 63809cd into main Nov 18, 2026
11 checks passed
@rich-iannone
rich-iannone deleted the gti-search-highlights branch November 18, 2026 04:11
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (a7002c2) to head (95a83da).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          73       73           
  Lines       14714    14714           
=======================================
  Hits        14525    14525           
  Misses        189      189           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant