Repository navigation
fix(install): wait up to 120s for the kubeconfig, like kubesoloctl - #230
Open
shubhamkapoor01 wants to merge 1 commit into
Open
shubhamkapoor01 wants to merge 1 commit into
shubhamkapoor01 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Adjust the loop so it checks for the kubeconfig through the full 120-second timeout.
1 open issue
What changed in this PR
This pull request extends install.sh’s kubeconfig wait period from 30 to 120 seconds to better support slow first boots, and clarifies the timeout warning.
Changes:
- Increases the kubeconfig polling limit to 120 seconds.
- Updates the timeout message to indicate that the cluster may still be starting.
| File | Description |
|---|---|
install.sh |
Extends the kubeconfig wait loop and updates the timeout warning; the final check may occur before the full 120-second deadline. |
Review effort: Lite
| echo "⏳ Waiting for kubesolo to generate kubeconfig..." | ||
| i=1 | ||
| while [ $i -le 30 ]; do | ||
| while [ $i -le 120 ]; do |
Author
There was a problem hiding this comment.
Good catch, the counter now starts at 0 so the last check happens at 120s. The old 30s loop had the same off-by-one.
shubhamkapoor01
force-pushed
the
install-kubeconfig-wait
branch
from
October 24, 2026 14:52
94d11b4 to
3b3bdbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install.sh gives up waiting for the admin kubeconfig after 30s. A first boot on a small device can take longer (kubesoloctl already waits 120s for this reason), so the kubeconfig never gets merged.
Fix
Wait up to 120s, the same as kubesoloctl's
kubeconfigWaitTimeout, and say the cluster may still be starting when it gives up. The exit code is unchanged.Related to #158