Skip to content

chore: remove duplicate license file - #6

Merged
0xhafa merged 1 commit into
mainfrom
chore/canonical-license
Sep 24, 2026
Merged

0xhafa merged 1 commit into
mainfrom
chore/canonical-license

Conversation

@0xhafa

@0xhafa 0xhafa commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Keep LICENSE as the single root license file and remove the byte-identical license.md duplicate. Update the package metadata, both package builders, and the existing artifact fixture to use LICENSE.

This cleanup was applied in the private source repository's develop branch, promoted to its main branch, and then copied here. Every retained file touched by this change matches the promoted source. Existing public-only adjustments remain intact; the license text is unchanged.

Validation: artifact bundle fixture, Solana package build, repository layout, signer grammar, source-content equality, and whitespace checks passed. The private source also passed the npm pack license-content check and upgrade-source integrity fixture.

@0xhafa
0xhafa merged commit a42e58c into main Sep 24, 2026
3 checks passed
@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking gap in artifact license regression coverage.

Findings

  1. P2 License output goes unchecked ▶

Summary

The PR removes a duplicate root license and updates package metadata, both package builders, and the artifact fixture to use LICENSE.

  • The retained license text is unchanged.
  • The artifact fixture does not verify the newly named output file.

Reviews (1) · Last reviewed commit: "chore: remove duplicate license file"


try {
writeFileSync(join(ROOT, 'license.md'), readFileSync(new URL('../license.md', import.meta.url)));
writeFileSync(join(ROOT, 'LICENSE'), readFileSync(new URL('../LICENSE', import.meta.url)));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 License output goes unchecked The fixture now supplies LICENSE to the builder, but its assertions never check the generated dist/nest-artifacts/LICENSE file or its contents. A future change that omits or misnames the bundled license could pass this fixture. Please assert that the generated file matches the root license.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant