chore: remove duplicate license file - #6
Conversation
|
|
|
||
| try { | ||
| writeFileSync(join(ROOT, 'license.md'), readFileSync(new URL('../license.md', import.meta.url))); | ||
| writeFileSync(join(ROOT, 'LICENSE'), readFileSync(new URL('../LICENSE', import.meta.url))); |
There was a problem hiding this comment.
License output goes unchecked The fixture now supplies
LICENSE to the builder, but its assertions never check the generated dist/nest-artifacts/LICENSE file or its contents. A future change that omits or misnames the bundled license could pass this fixture. Please assert that the generated file matches the root license.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Keep
LICENSEas the single root license file and remove the byte-identicallicense.mdduplicate. Update the package metadata, both package builders, and the existing artifact fixture to useLICENSE.This cleanup was applied in the private source repository's
developbranch, promoted to itsmainbranch, and then copied here. Every retained file touched by this change matches the promoted source. Existing public-only adjustments remain intact; the license text is unchanged.Validation: artifact bundle fixture, Solana package build, repository layout, signer grammar, source-content equality, and whitespace checks passed. The private source also passed the npm pack license-content check and upgrade-source integrity fixture.