Skip to content

chore: remove internal signer Slack skill #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xhafa merged 1 commit into from
Sep 21, 2026
Merged

chore: remove internal signer Slack skill #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions .agents/skills/signer-slack-msg/SKILL.md
View file
Open in desktop

This file was deleted.

67 changes: 4 additions & 63 deletions tools/check-signer-message-grammar.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
#!/usr/bin/env node
// Pin check for the shared signer-message grammar.
//
// The generator (.agents signer-slack-msg skill) and the verifier
// (plume-hub:packages/safe-verify) must agree on exactly one grammar. Both
// repositories carry a byte-identical copy of docs/signer-message-grammar.md and
// pin its SHA-256; a copy that drifts on either side fails its own check instead
// of being silently reinterpreted.
// The public grammar reference must match the verifier copy in
// plume-hub:packages/safe-verify. Both repositories pin its SHA-256; a copy that
// drifts on either side fails its own check instead of being silently reinterpreted.
//
// node tools/check-signer-message-grammar.mjs
//
Expand All @@ -21,7 +19,6 @@ export const GRAMMAR_REFERENCE_PATH = "docs/signer-message-grammar.md";
export const GRAMMAR_REFERENCE_SHA256 =
"d5e4d18e0d558ece88c16bd2489a4a79c687736f1a9a3ac815f6f1088f496e55";

const SKILL_PATH = ".agents/skills/signer-slack-msg/SKILL.md";
const faults = [];

const referencePath = join(ROOT, GRAMMAR_REFERENCE_PATH);
Expand All @@ -45,62 +42,6 @@ if (!existsSync(referencePath)) {
}
}

const skillPath = join(ROOT, SKILL_PATH);
if (!existsSync(skillPath)) {
faults.push(`${SKILL_PATH} is missing`);
} else {
const text = readFileSync(skillPath, "utf8");
if (!text.includes(GRAMMAR_VERSION))
faults.push(`${SKILL_PATH} does not pin ${GRAMMAR_VERSION}`);
if (!text.includes("grammar: " + GRAMMAR_VERSION))
faults.push(`${SKILL_PATH} does not show the grammar pragma`);
if (!text.includes("op=call value=0"))
faults.push(
`${SKILL_PATH} does not require explicit op=/value= on every call`,
);

// Every example call line is itself an instruction: an incomplete one teaches the generator to
// emit a message the canonical parser rejects. Each is checked for the mandatory modifiers.
const lines = text.split("\n");
lines.forEach((line, position) => {
const call = /^\s*(?:\[\d+\]|└─?|↳|\\_)\s*(.+)$/.exec(line);
if (!call) return;
const body = call[1].replace(/\s+#.*$/, "");
const where = `${SKILL_PATH}:${position + 1}`;
// `[1] …` is an elision inside the shape template, not a declared call. Only a bare ellipsis
// qualifies; anything else must be a complete call line, arrow included.
if (/^(?:…|\.{3})$/.test(body.trim())) return;
if (!body.includes("->")) {
faults.push(`${where} example call line declares no -> <target>`);
return;
}
if (!/\bop=(call|delegatecall)\b/.test(body))
faults.push(`${where} example call line declares no op=`);
if (!/\bvalue=\S+/.test(body))
faults.push(`${where} example call line declares no value=`);

const isUnknown = /\bUNKNOWN\s+0x[0-9a-fA-F]{8}\b/.test(body);
const isNativeTransfer = /\bnativeTransfer\(\s*\)/.test(body);
const hasSignature = /\bsig=\S/.test(body);
if (!isUnknown && !isNativeTransfer && !hasSignature) {
faults.push(
`${where} example call line declares no sig=<name(type,type)>`,
);
}
if ((isUnknown || isNativeTransfer) && hasSignature) {
faults.push(
`${where} example call line declares sig= on a call that pins no signature`,
);
}
});

// A parenthesised role gloss is opaque to the verifier; the documented form is `15/SEIZER`.
if (/\brole=\d+\s*\(/.test(text))
faults.push(
`${SKILL_PATH} shows the opaque \`role=<n> (name)\` form instead of <n>/<NAME>`,
);
}

if (faults.length) {
console.error(
`[signer-grammar] FATAL ${faults.length} problem(s):\n` +
Expand All @@ -110,5 +51,5 @@ if (faults.length) {
}

console.log(
`[signer-grammar] ${GRAMMAR_VERSION} pinned; ${GRAMMAR_REFERENCE_PATH} sha256 ${GRAMMAR_REFERENCE_SHA256}; generator skill agrees`,
`[signer-grammar] ${GRAMMAR_VERSION} pinned; ${GRAMMAR_REFERENCE_PATH} sha256 ${GRAMMAR_REFERENCE_SHA256}`,
);
Loading