Skip to content

Handle cvc5 version output on stderr in macOS CI - #1

Closed
pleich with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Closed

pleich with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Sep 24, 2026 •

Copy link
Copy Markdown

Tests (MacOS) was failing in taco-smt-encoder despite cvc5 being installed, because version discovery only parsed stdout while the Homebrew cask path can emit --version output on stderr. This updates solver version detection to accept either stream without changing solver-selection semantics.

  • Root cause

    • get_smt_solver_version treated missing parseable stdout as failure, even when stderr contained a valid version string.
  • Implementation

    • Added parse_smt_solver_version_output(stdout, stderr) to parse version from both streams.
    • Updated get_smt_solver_version to:
      • return success when either stream yields a valid version,
      • preserve existing NotInstalled behavior when execution fails and no version is parseable,
      • otherwise return ParseVersionError.
  • Coverage

    • Added a focused unit test for stderr-based version parsing (test_parse_version_from_stderr) to lock behavior for cvc5/macOS-style output.
if let Ok(version) = parse_smt_solver_version_output(&out.stdout, &out.stderr) {
    return Ok(version);
}

Co-authored-by: pleich <60977980+pleich@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job Tests (MacOS) Handle cvc5 version output on stderr in macOS CI Sep 24, 2026
Copilot AI requested a review from pleich September 24, 2026 11:58
@pleich pleich closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants