Repository navigation
fix: keep a cubemap's name when prefiltering it - #2522
Merged
Merged
Conversation
The prefilter uploaded its file with the cubemap's name plus an extension as the asset name, so the server renamed the cubemap on every prefilter (sky, sky.png, sky.png.png). Name only the uploaded file, without the extensions earlier prefilters added.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kpal81xd
approved these changes
Nov 17, 2026
kpal81xd
requested changes
Nov 17, 2026
kpal81xd
left a comment
Contributor
There was a problem hiding this comment.
Not sending name fixes the rename, verified: sky stays sky and its file is sky.png.
The extension strip has no effect though. On update the backend names the stored file from the asset name and ignores filename, so a cubemap already renamed to sky.png.png keeps the file sky.png.png after prefiltering. Please drop the strip, its comment and the second bullet in the description.
kpal81xd
approved these changes
Nov 18, 2026
kpal81xd
left a comment
Contributor
There was a problem hiding this comment.
Verified on dev with the PR build: prefiltering sky2 twice keeps the name sky2 and the file sky2.png. The deployed 2.35.29 build renamed sky to sky.png.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefiltering a cubemap renamed the cubemap asset, adding another extension every time:
sky→sky.png→sky.png.png.Changes:
nameset to the cubemap's name plus the extension, and the asset update appliesnameto the asset. It now names only the uploaded file, so the cubemap keeps its name and its file is<name>.png, or<name>.ddsfor the legacy format.