Skip to content

fix: keep a cubemap's name when prefiltering it - #2522

Merged
kpal81xd merged 4 commits into
mainfrom
mv-cubemap-prefilter-name
Nov 18, 2026
Merged

kpal81xd merged 4 commits into
mainfrom
mv-cubemap-prefilter-name

Conversation

@mvaligursky

@mvaligursky mvaligursky commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Prefiltering a cubemap renamed the cubemap asset, adding another extension every time: sky → sky.png → sky.png.png.

Changes:

  • The prefilter uploaded its file with name set to the cubemap's name plus the extension, and the asset update applies name to the asset. It now names only the uploaded file, so the cubemap keeps its name and its file is <name>.png, or <name>.dds for the legacy format.

The prefilter uploaded its file with the cubemap's name plus an extension as the
asset name, so the server renamed the cubemap on every prefilter (sky, sky.png,
sky.png.png). Name only the uploaded file, without the extensions earlier
prefilters added.
@mvaligursky mvaligursky self-assigned this Nov 17, 2026
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
editor Ready Ready Preview Nov 18, 2026 4:43pm UTC

Request Review

@mvaligursky mvaligursky added release: next patch Ticket marked for next patch release bug Something isn't working labels Nov 17, 2026

@kpal81xd kpal81xd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sending name fixes the rename, verified: sky stays sky and its file is sky.png.

The extension strip has no effect though. On update the backend names the stored file from the asset name and ignores filename, so a cubemap already renamed to sky.png.png keeps the file sky.png.png after prefiltering. Please drop the strip, its comment and the second bullet in the description.

@kpal81xd kpal81xd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on dev with the PR build: prefiltering sky2 twice keeps the name sky2 and the file sky2.png. The deployed 2.35.29 build renamed sky to sky.png.

@kpal81xd
kpal81xd merged commit e6ec3b9 into main Nov 18, 2026
8 checks passed
@kpal81xd
kpal81xd deleted the mv-cubemap-prefilter-name branch November 18, 2026 16:44

This branch was successfully deployed

1 active deployment
Preview — b1e448b1 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release: next patch Ticket marked for next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants