Repository navigation
docs: clarify the skybox note and retire the legacy Splat Publishing page - #1384
Merged
Merged
Conversation
…page Experience Settings said the viewer doesn't load the skybox from the settings. That's true of the open-source viewer, but superspl.at's scene pages and embeds still show the Studio skybox, because superspl.at passes it to the viewer itself. Say so, in English and Japanese. Remove the unlisted /user-manual/api/splat-publish/ page, which described an older upload flow and had no inbound links. Its URL now redirects to SuperSplat's API & Integrations. That page was the corpus test's only example of an unlisted doc, so the test now checks that every unlisted or draft doc is left out of llms-full.txt, rather than naming one page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups from the SuperSplat audit.
Skybox note
Experience Settings › How the viewer reads it said: "the viewer doesn't load the skybox from the settings."
That's true of the open-source viewer, but it read as if Studio skyboxes don't reach visitors. They do. superspl.at's scene page starts the viewer with the scene's
skyboxUrlfrom the page's own data (#sse-bootstrap), the same way it applies the anti-aliasing setting (#1380). The bullet now says the open-source viewer doesn't load it, but superspl.at scene pages and embeds still show the skybox you upload in Studio, and when self-hosting you pass it withskyboxorskyboxUrl. Japanese is updated to match.Legacy Splat Publishing page
/user-manual/api/splat-publish/was an unlisted page describing the olderplaycanvas.com/api/splats/publishupload flow (a signed S3 URL, then a processing job). Nothing linked to it after #1368 pointed its last links at API & Integrations.git rm./user-manual/supersplat/developers/api-integrations/, so old bookmarks land on the current API docs.Test change
utils/plugins/llms/test/corpus.test.mjshad a test, "leaves out unlisted docs", that checkedllms-full.txtdidn't contain this page by name. It was the corpus's only unlisted doc, so the test would have passed without checking anything. It's now "leaves out unlisted and draft docs": it finds every doc withunlisted: trueordraft: trueand checks that each one is left out. Right now no docs are unlisted or drafts, so it has nothing to check until one exists.Checks
npm run lint: 0 issuesnpm test: 52/52 pass, including the rewritten testnpm run build(en and ja): succeeds with no broken-link or broken-anchor warnings./user-manual/api/splat-publish/and/ja/user-manual/api/splat-publish/redirect to API & Integrations.Made in a separate git worktree, so it doesn't touch the in-progress
<kbd>work in the main checkout.🤖 Generated with Claude Code