Repository navigation
Pass SYNC_TOKEN to the studio frontend build - #129
Merged
Merged
Conversation
Build commits are pushed as pimcore-deployments and only on version branches; PR runs upload the build as an artifact instead (pimcore/workflows-collection-public#168, DevOps-Tasks#65). The push run no longer cancels an in-progress run, the head-commit check in the reusable prevents a commit loop.
berfinyuksel
added
the
Skip Milestone Check
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of pimcore/DevOps-Tasks#65. The studio frontend build pushes its automatic commits as pimcore-deployments and only on pushes to version branches; PR runs upload the build as an artifact instead (pimcore/workflows-collection-public#168). The push run no longer cancels an in-progress run; the head-commit check in the reusable prevents a commit loop.
Until #168 is merged the "Studio Frontend Build" check fails at startup with "secret SYNC_TOKEN is not defined in the referenced workflow". That is expected; the check gets re-run after the merge, before this PR is marked ready.