[CI] Build the codeception matrix from the base branch (2.4) - #701
Merged
Merged
Conversation
berfinyuksel
added
the
Skip Milestone Check
berfinyuksel
marked this pull request as ready for review
September 21, 2026 13:36
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The targeted workflow change correctly prevents PR-head control of matrix inputs.
Review effort: Balanced
Findings: None
What changed in this PR
Hardens Codeception CI matrix generation by using trusted base-branch configuration.
Changes:
- Checks out the PR base ref before reading
composer.json. - Falls back to the workflow ref for non-PR triggers.
| File | Description |
|---|---|
.github/workflows/codeception.yml |
Selects the trusted ref for matrix setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of pimcore/product-management#1430.
Syncs the matrix-source hardening that
2026.xalready has into.github/workflows/codeception.ymlon2.4: thesetup-matrixjob now checks out the PR's base ref and builds the test matrix from thatbranch's
composer.json, instead of the PR head. The matrix must not be attacker-controlled(this caller triggers on
pull_request).The file becomes byte-identical to its
2026.xversion; the only difference was this hunk.Forward-merge chain after merge: 2.4 → 2026.2 → 2026.x (2026.2 and 2026.x already identical, no-op there) (direct merges, no PRs).