Repository navigation
Conversation
Author
|
The Linux test failures are not caused by this change. Other PRs have hit the same errors (memrchr in extgen, GLib abort) since Nov 12. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2838.
On Windows, PHP's
win32/syslog.hdoesn't use the standard syslog priorities (LOG_ERRis 4,LOG_WARNINGis 5,LOG_NOTICEandLOG_INFOare both 6), butgo_log()reads them as standard values. So a fatal error was logged aswarnand a warning asinfo. The log callback now maps the Windows values back to the standard ones before passing them to Go.The new test runs on the Windows CI job and fails there without the fix.