Skip to content

ci: build with the latest Go patch release - #2776

Merged
dunglas merged 2 commits into
mainfrom
ci/setup-go-latest-patch
Oct 26, 2026
Merged

dunglas merged 2 commits into
mainfrom
ci/setup-go-latest-patch

Conversation

@dunglas

@dunglas dunglas commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

setup-go read go 1.27.0 from go.mod as an exact version, so check-latest never applied. Windows, macOS and release.yaml builds have been using Go 1.27.0, and the v1.13.3 Windows and macOS binaries are affected by GO-2026-6617 (HTTP/2 server crash from an HPACK encoder race, fixed in Go 1.27.2). Docker images and Linux static binaries already used the latest patch release.

  • go.mod and caddy/go.mod now declare go 1.27, so go-version-file gives setup-go the minor version and check-latest resolves the latest 1.27.x on every run. go mod tidy keeps this form.
  • Lint fails on a patch release in a go directive or on any toolchain directive. Both pin CI to a release that goes stale, go get adds them back on its own, and Dependabot doesn't update them (dependabot/dependabot-core#9527).

Unblocks #2729, which flags GO-2026-6617 while CI runs Go 1.27.0.

setup-go reads "go 1.27.0" in go.mod as an exact version, so check-latest
never applied: Windows and macOS release binaries shipped with Go 1.27.0,
affected by GO-2026-6617 (HTTP/2 HPACK encoder race, fixed in 1.27.2).
Without a patch number, setup-go resolves the latest 1.27 release.
A patch release in the go or toolchain directive pins CI to it and goes
stale, and go get adds them back on its own.
@dunglas
dunglas force-pushed the ci/setup-go-latest-patch branch from c79303f to cb37041 Compare October 26, 2026 09:26
@dunglas
dunglas merged commit e30c5ed into main Oct 26, 2026
43 checks passed
@dunglas
dunglas deleted the ci/setup-go-latest-patch branch October 26, 2026 09:41
dunglas added a commit that referenced this pull request Nov 5, 2026
Updates the root and `caddy` modules, including Caddy 2.11.9, Mercure
1.1.6, Vulcain 1.4.6 and golang.org/x/net 0.62.0.

- quic-go is held at v0.64.1: v0.65.0 removes
`h3qlog.DefaultConnectionTracer`, which Caddy 2.11.9 still uses.
- Caddy 2.11.9 makes the last entry of `first_exist_fallback` match even
when the file doesn't exist. `php_server` relied on the existence check
on Unix, so without an `index.php` it now reached PHP ("No input file
specified.") instead of returning Caddy's 404 and falling through. It
now uses `first_exist`, like Windows and the `php-server` command
already did.
- `caddy/go.mod` now requires Go 1.27.3, because mercure/caddy,
vulcain/caddy and slackhq/nebula do. `go get` adds that patch release
back, so the lint rule from #2776
can't hold. The `setup-go` action now requests `1.27` with
`check-latest` instead of reading `go.mod`, so every workflow builds
with the latest 1.27 patch release whatever `go.mod` requires, as in
dunglas/mercure#1470.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant