Skip to content

fix: build against PHP 8.6 - #2772

Closed
dunglas wants to merge 1 commit into
mainfrom
fix/php86-current-user
Closed

dunglas wants to merge 1 commit into
mainfrom
fix/php86-current-user

Conversation

@dunglas

@dunglas dunglas commented Oct 26, 2026

Copy link
Copy Markdown
Member

PHP 8.6 converted sapi_request_info.current_user to a zend_string * and dropped current_user_length (php/php-src@5795e330a6a), so the reset added for GHSA-h764-4wh7-m7j2 doesn't compile there. PHP 8.6 already clears these pointers in sapi_deactivate_module() (php/php-src@642fa8c9), so the reset is only needed before 8.6.

PHP 8.6 dropped sapi_request_info.current_user_length and already clears the
pointers sapi_deactivate() frees.
@dunglas

dunglas commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

Duplicate of #2770, which landed the same change.

@dunglas dunglas closed this Oct 26, 2026
@dunglas
dunglas deleted the fix/php86-current-user branch October 26, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant