Add :html_formats option - #14
Merged
Merged
Conversation
josevalim
reviewed
Sep 21, 2026
josevalim
reviewed
Sep 21, 2026
Co-authored-by: José Valim <jose.valim@gmail.com>
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
.eextemplates are compiled withPhoenix.HTML.Engineonly when the encoder of their format isPhoenix.HTML.Engine. A format with its own encoder, such as MJML emails compiled to HTML, falls back toEEx.SmartEngineand interpolates values unescaped.This adds the
:html_formatsoption, as discussed in the issue:Templates of the listed formats are compiled exactly like
.html.eexones: values are escaped unless marked as safe,:trim_on_html_eex_engineapplies, and the format encoder receives the{:safe, iodata}tuple.Nothing changes for apps that do not set the option. The error raised when
phoenix_htmlis missing now names the actual format instead of.html.eex.