Repository navigation
Clear pending disconnected timer before scheduling another - #4464
Open
lukaszsamson wants to merge 1 commit into
Open
lukaszsamson wants to merge 1 commit into
lukaszsamson wants to merge 1 commit into
Conversation
SteffenDE
reviewed
Oct 6, 2026
Comment on lines
+1456
to
1459
| this.disconnectedTimer != null && clearTimeout(this.disconnectedTimer); | ||
| this.disconnectedTimer = setTimeout(() => { | ||
| this.execAll(this.binding("disconnected")); | ||
| }, this.liveSocket.disconnectedTimeout); |
Member
There was a problem hiding this comment.
That will delay showing an error, while it might be better to early exit if there's already one scheduled, since hideLoader already cancels.
Suggested change
| this.disconnectedTimer != null && clearTimeout(this.disconnectedTimer); | |
| this.disconnectedTimer = setTimeout(() => { | |
| this.execAll(this.binding("disconnected")); | |
| }, this.liveSocket.disconnectedTimeout); | |
| if (this.disconnectedTimer != null) { return }; | |
| this.disconnectedTimer = setTimeout(() => { | |
| this.disconnectedTimer = null; | |
| this.execAll(this.binding("disconnected")); | |
| }, this.liveSocket.disconnectedTimeout); |
Wdyt?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR stale timer can stack and firee
phx-disconnectedafter reconnect resulting in "offline" banner that never clears