Skip to content

Fix optional attributes in RelaxNG schema for VSCode - #2003

Merged
mrook merged 3 commits into
phingofficial:mainfrom
mallowmew:fix-optional-in-grammar
Nov 5, 2026
Merged

mrook merged 3 commits into
phingofficial:mainfrom
mallowmew:fix-optional-in-grammar

Conversation

@mallowmew

@mallowmew mallowmew commented Apr 14, 2026 •

Copy link
Copy Markdown
Contributor

The RelaxNG schema support in VSCode via the Red Hat XML extension needs an <optional> tag around each attribute that is optional. It doesn't seem to work with a number of attributes nested within a single <optional> tag. I don't know if this is necessary in other editors.

@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.59%. Comparing base (acf989c) to head (4db314d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2003   +/-   ##
=========================================
  Coverage     52.59%   52.59%           
  Complexity     9819     9819           
=========================================
  Files           496      496           
  Lines         24171    24171           
=========================================
  Hits          12712    12712           
  Misses        11459    11459           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrook
mrook merged commit ab4f512 into phingofficial:main Nov 5, 2026
31 checks passed
mrook added a commit that referenced this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants