Repository navigation
Conversation
Describe reader configuration, source precedence, prefixes and inheritance for the model table resolution fix in phalcon/cphalcon#17742. Link the annotations guide to the model guide and state the release requirement. Assisted-by: Codex
5 tasks done
Explain that missing, empty and non-string Source table names raise InvalidSourceTable during source resolution, matching phalcon/cphalcon#17742. Assisted-by: Codex
Bring in the upstream 5.24 documentation tree before moving the pending Source integration guide to the upcoming release. Assisted-by: Codex
Move the model Source attribute guide and annotations cross-reference to the newly available 5.24 documentation. Restore the released 5.23 guides and retain the availability note linking the unreleased framework fix. Assisted-by: Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document opt-in ORM table resolution from
#[Source]in the Phalcon 5.24 guides, matching phalcon/cphalcon#17742 and its review request: phalcon/cphalcon#17742 (comment).The model guide shows how to select
AttributesReaderbefore usingSource, explains named and positional arguments, explicit-source precedence, table prefixes, per-class caching, inheritance, and compatibility with the configured metadata strategy. It also documentsInvalidSourceTablefor missing, empty, or non-string table names. The annotations guide links to this section; PHPDoc@Sourceremains ignored for table resolution.The availability note states that Phalcon 5.23.0 lacks this behavior and requires a release containing the framework fix. The framework PR is still under review. The new guidance lives in the upcoming 5.24 documentation; the released 5.23 guides retain their existing behavior.
Related: phalcon/cphalcon#17741, phalcon/cphalcon#17742.
Validation after syncing upstream master and moving the guide to 5.24:
@mdx-js/mdx.pnpm buildpasses: 3152 pages built.pnpm lint:docspasses: 3153 files lint clean.accounting_invoices.git diff --checkpasses.The final diff against master changes only
docs-5.24/annotations.mdxanddocs-5.24/db-models.mdx; generated API pages, routes and released-version manuals are unchanged.